Emit a remoteMethodDisabled event when disabling a remote method - #2266
Merged
superkhau merged 1 commit intoApr 28, 2016
Merged
Conversation
|
Can one of the admins verify this patch? To accept patch and trigger a build add comment ".ok\W+to\W+test." |
This was referenced Apr 27, 2016
Merged
| this.emit('modelRemoted', Model.sharedClass); | ||
| } | ||
|
|
||
| _self = this; |
Contributor
|
Minor comments, please fix them and squash the commits. |
supasate
force-pushed
the
feature/emit-remote-method-disabled-event
branch
from
April 28, 2016 02:01
0701b85 to
be5a4b3
Compare
… a remote method. Signed-off-by: Supasate Choochaisri <supasate.c@gmail.com>
supasate
force-pushed
the
feature/emit-remote-method-disabled-event
branch
from
April 28, 2016 02:04
be5a4b3 to
0ca2438
Compare
Contributor
Author
|
@superkhau I've fixed them. Please check. |
Contributor
|
LGTM. Thanks for the contribution! ;) |
Contributor
Author
|
@superkhau There is another PR (strongloop/loopback-component-explorer#157) that consumes this feature to make #686 complete. |
Member
|
@superkhau have you back-ported this patch to |
superkhau
pushed a commit
that referenced
this pull request
Apr 29, 2016
superkhau
pushed a commit
that referenced
this pull request
Apr 29, 2016
Contributor
Contributor
|
I also notice a few errors within the merged PR, so I submitted another PR with the fixes on it. See #2271 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR for #686 to make loopback emits a remoteMethodDisabled event. I'll make another PR for loopback-component-explorer to register for this event.